Settings and activity
5 results found
-
34 votes
An error occurred while saving the comment 
Truan
supported this idea
·
-
51 votesTruan
supported this idea
·
An error occurred while saving the comment Truan
commented
I am not sure this is just due to a bad, or even slow, review process. We have situations where reviews are created when initial changes are pushed, so there is no issue with the sliders/diffs there, but if rework is required we want to add the changeset for the rework to the original review to show it has been done, this can easily result in the changesets spanning other changes.
If the original review is for change 123, we see the slider showing 122-123, the review is rejected with rework required - when the rework is completed it is change 127, the slider will show 122-123-127... I would suggest it should show something like 122-123-126-127, so you can see the changes just due to the new change.
It is possible to do this manually, but it can cause problems with which review changeset 126 is associated with (it may have been associated with a closed review, adding it to a new one ends up flagging the changeset as being associated with an 'open' review again
-
7 votesTruan
supported this idea
·
-
10 votesTruan
supported this idea
·
-
60 votesTruan
supported this idea
·
We are looking for similar functionality to support automatic creation of reviews (and possibly closure of reviews) in response to creation/acceptance of merge requests in git.