Change "Reject Changes" to "Recommend rework"
"Accept changes" is a good disposition, but it strikes me as suboptimal to have the alternative be "reject changes". It seems like that implies that the changes should be rolled back or totally undone. More often, we want to say that "I am done with the review and I think something needs to be changed."
So perhaps there is a better way to word it, but the best I can think of is that the ways to Complete Review should be "Accept changes" and "Recommend rework". Perhaps "Reject changes" could be a third option, but I wouldn't use it very much.
-
Patrick Szalapski commented
-
Mark Freeman commented
To me, there are two types of defects: 1) This cannot be promoted to production as is; 2) This is OK for now but needs to be refactored.
There is no way to indicate that except to type it out for each defect, which is tedious at best.
Perhaps instead of a checkbox for Defect, there could be a drop-down with choices such as "Must fix" or "Should fix" or "Must fix for next release".
-
Patrick Szalapski commented
Without this feature, I finish doing reviews but leave them in "pending" hoping the author revisits it.